#35 Cosmetics/useless fixes to Sinatra's own app used to handle errors

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:id	tickets sorted by id (creation time)
Combine keywords for powerful searching.
Use advanced searching »

#35 √ resolved

Cosmetics/useless fixes to Sinatra's own app used to handle errors

Reported by Simon Rozet | July 8th, 2008 @ 11:46 AM | in 0.3.0 Sammy

Those aren't even a bug but still, I though I'd "fix" those:

the images used in the 404 page or when an exception is raised aren't served with the correct mime-type.

 isn't closed in the params inspection block (again, for when an error is raised)

Simon Rozet July 8th, 2008 @ 01:34 PM
I also pushed a small change which DRY a bit the default event error and ensure that the markup is valid HTML4.
Ryan Tomayko September 7th, 2008 @ 07:49 AM
I've incorporated most of this into my master. Everything's been trimmed down significantly and I'm using an HTML 5 doctype instead of HTML 4 but other than that I think everything made it in.
Ryan Tomayko September 7th, 2008 @ 06:13 PM
- → Tag changed from “patch pull” to “fixed patch pull”
- → State changed from “new” to “resolved”

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »