1 false 2008-06-09T01:09:02-07:00 9991 2012-12-31T00:00:00-08:00 27724 31 nested-resources 2 9779 new "feature patch" routes routing 2010-01-21T17:21:35-08:00 47545 Mike (at coverallcrew) Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future Ok here's the more controversial feature addition. Feel free to shoot it down. :) Nested resources: @@@ resource 'posts' do get do # show all posts end post do # create new post end end resource 'posts/:id' do get do # show post params[:id] end delete do # destroy post params[:id] end get 'comments' do # show this post's comments end end @@@ The patch: http://github.com/adamwiggins/sinatra/commit/b0b67602be141dcc835e91443e3120e5b1acbc9d I was hesitant about this idea, since I do really like that typing "egrep '^(get|put|post|delete)' myapp.rb" returns all the full URLs. But for larger apps, having a bit more organization is really nice. And since it only adds ~20 lines of code and doesn't disrupt any existing syntax, it seemed like a net win overall. Curious to hear feedback. Ok here's the more controversial feature addition. Feel free to shoot it down. :) Nested resources: @@@ resource 'posts' do get do # show all posts end post do # create new post end end resource 'posts/:id' do get do # show post params[:id] end delete do # destroy post params[:id] end get 'comments' do # show this post's comments end end @@@ The patch: http://github.com/adamwiggins/sinatra/commit/b0b67602be141dcc835e91443e3120e5b1acbc9d I was hesitant about this idea, since I do really like that typing "egrep '^(get|put|post|delete)' myapp.rb" returns all the full URLs. But for larger apps, having a bit more organization is really nice. And since it only adds ~20 lines of code and doesn't disrupt any existing syntax, it seemed like a net win overall. Curious to hear feedback. <div><p> Ok here's the more controversial feature addition. Feel free to shoot it down. :) </p><p> Nested resources: </p> <pre><code class="">resource 'posts' do get do # show all posts end post do # create new post end end resource 'posts/:id' do get do # show post params[:id] end delete do # destroy post params[:id] end get 'comments' do # show this post's comments end end </code></pre> <p> The patch: </p><p> <a href="http://github.com/adamwiggins/sinatra/commit/b0b67602be141dcc835e91443e3120e5b1acbc9d">http://github.com/adamwiggins/si...</a> </p><p> I was hesitant about this idea, since I do really like that typing "egrep '^(get|put|post|delete)' myapp.rb" returns all the full URLs. But for larger apps, having a bit more organization is really nice. And since it only adds ~20 lines of code and doesn't disrupt any existing syntax, it seemed like a net win overall. </p><p> Curious to hear feedback. </p></div> 15214 0 Ok here's the more controversial feature addition. Feel free to shoot it down. :) Nested resources: @@@ resource 'posts' do get do # show all posts end post do # create new post end end resource 'posts/:id' do get do # show post params[:id] end delete do # destroy post params[:id] end get 'comments' do # show this post's comments end end @@@ The patch: http://github.com/adamwiggins/sinatra/commit/b0b67602be141dcc835e91443e3120e5b1acbc9d I was hesitant about this idea, since I do really like that typing "egrep '^(get|put|post|delete)' myapp.rb" returns all the full URLs. But for larger apps, having a bit more organization is really nice. And since it only adds ~20 lines of code and doesn't disrupt any existing syntax, it seemed like a net win overall. Curious to hear feedback. <div><p> Ok here's the more controversial feature addition. Feel free to shoot it down. :) </p><p> Nested resources: </p> <pre><code class="">resource 'posts' do get do # show all posts end post do # create new post end end resource 'posts/:id' do get do # show post params[:id] end delete do # destroy post params[:id] end get 'comments' do # show this post's comments end end </code></pre> <p> The patch: </p><p> <a href="http://github.com/adamwiggins/sinatra/commit/b0b67602be141dcc835e91443e3120e5b1acbc9d">http://github.com/adamwiggins/si...</a> </p><p> I was hesitant about this idea, since I do really like that typing "egrep '^(get|put|post|delete)' myapp.rb" returns all the full URLs. But for larger apps, having a bit more organization is really nice. And since it only adds ~20 lines of code and doesn't disrupt any existing syntax, it seemed like a net win overall. </p><p> Curious to hear feedback. </p></div> false 2008-06-09T01:09:02-07:00 9991 --- {} 9332 31 nested-resources 0 9779 new 2008-06-09T01:09:02-07:00 9991 Adam Wiggins Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.3.0 Sammy Blake Mizerany 15214 0 Rereading this, I probably should have mentioned that url paths are concatenated. So fetching a post's comments would look like this: @@@ RestClient.get 'http://localhost:4567/posts/1/comments' @@@ <div><p> Rereading this, I probably should have mentioned that url paths are concatenated. So fetching a post's comments would look like this: </p> <pre><code class="">RestClient.get 'http://localhost:4567/posts/1/comments' </code></pre></div> false 2008-06-09T01:12:44-07:00 9991 --- {} 9332 31 nested-resources 0 9779 new 2008-06-09T01:12:44-07:00 9991 Adam Wiggins Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.3.0 Sammy Blake Mizerany 15214 0 I like that this tidies things up. Let me play with it for a bit. This is looking great. <div><p> I like that this tidies things up. Let me play with it for a bit. This is looking great. </p></div> false 2008-06-09T16:01:31-07:00 9991 --- {} 9332 31 nested-resources 0 9779 new 2008-06-09T16:01:31-07:00 15214 Blake Mizerany Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.3.0 Sammy Blake Mizerany 15214 0 I'm diggin this, too. :) I haven't looked at the patch yet but the syntax looks tasty. <div><p> I'm diggin this, too. :) </p><p> I haven't looked at the patch yet but the syntax looks tasty. </p></div> false 2008-06-10T05:12:26-07:00 9991 --- {} 9332 31 nested-resources 0 9779 new 2008-06-10T05:12:26-07:00 17123 Ryan Tomayko Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.3.0 Sammy Blake Mizerany 15214 0 Branch against next: http://github.com/adamwiggins/sinatra/commits/nested_resources This patch is still considered experimental and may not be accepted or may change significantly pending design discussions. So I'm not tagging this one with "pull" <div><p> Branch against next: </p><p> <a href="http://github.com/adamwiggins/sinatra/commits/nested_resources">http://github.com/adamwiggins/si...</a> </p><p> This patch is still considered experimental and may not be accepted or may change significantly pending design discussions. So I'm not tagging this one with "pull" </p></div> false 2008-06-23T13:54:54-07:00 9991 --- {} 9332 31 nested-resources 0 9779 new 2008-06-23T13:54:54-07:00 9991 Adam Wiggins Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.3.0 Sammy Blake Mizerany 15214 0 +1. I love this idea. I had one suggestion though, but feel free to tell me to create a new ticket if you think this should be considered separately from this feature. In your second resource block, where you have the :id parameter in the URL, what if the method blocks yield'ed with the parameters extracted from the URL? For example: @@@ruby resource 'posts/:id' do get do |id| # show post with id end delete do |id| # destroy post with id end get 'comments' do |id| # show comments of post with id end end @@@ <div><ol> <li>I love this idea. I had one suggestion though, but feel free to tell me to create a new ticket if you think this should be considered separately from this feature.</li> </ol> <p>In your second resource block, where you have the :id parameter in the URL, what if the method blocks yield'ed with the parameters extracted from the URL? For example:</p> <p>@@@ruby resource 'posts/:id' do get do |id|</p> <pre><code># show post with id </code></pre> <p> end</p> <p> delete do |id|</p> <pre><code># destroy post with id </code></pre> <p> end</p> <p> get 'comments' do |id|</p> <pre><code># show comments of post with id </code></pre> <p> end end</p> <pre><code> </code></pre></div> false 2008-08-14T19:24:55-07:00 9991 --- :tag: 9332 31 nested-resources 0 9779 new feature patch 2008-08-14T19:24:55-07:00 5609 Dan Kubb (dkubb) Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.3.0 Sammy Blake Mizerany 15214 0 Wow, I fubared the formatting on that, and I don't have access to edit it after posting. Here's a gist showing what I mean: http://gist.github.com/5524 <div><p>Wow, I fubared the formatting on that, and I don't have access to edit it after posting. Here's a gist showing what I mean: <a href="http://gist.github.com/5524">http://gist.github.com/5524</a></p></div> false 2008-08-14T19:26:56-07:00 9991 --- {} 9332 31 nested-resources 0 9779 new feature patch 2008-08-14T19:26:56-07:00 5609 Dan Kubb (dkubb) Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.3.0 Sammy Blake Mizerany 15214 0 I'd like to move this to 0.4 and the redux branch if there's no objections. Feels like the new code layout would be more accepting of such a change. <div><p>I'd like to move this to 0.4 and the redux branch if there's no objections. Feels like the new code layout would be more accepting of such a change.</p></div> false 2008-09-07T18:26:02-07:00 9991 --- :milestone: 9332 31 nested-resources 0 9779 new feature patch 2008-09-07T18:26:05-07:00 17123 Ryan Tomayko Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Blake Mizerany 17123 0 Killer feature. Moving to hoboken and putting on hold for now but this should be fairly easy to add once things settle down. <div><p>Killer feature. Moving to hoboken and putting on hold for now but this should be fairly easy to add once things settle down.</p></div> true 2008-12-30T02:48:32-08:00 9991 --- :milestone: 18496 :state: new :assigned_user: 15214 27290 31 nested-resources 0 9779 hold feature patch 2008-12-30T02:48:34-08:00 17123 Ryan Tomayko Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.9.0 Hoboken Ryan Tomayko 17123 0 false 2008-12-30T03:00:38-08:00 9991 --- :state: hold 27290 31 nested-resources 0 9779 new feature patch 2008-12-30T03:00:40-08:00 17123 Ryan Tomayko Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.9.0 Hoboken Ryan Tomayko 17123 0 false 2009-01-07T11:11:12-08:00 9991 --- :milestone: 27290 27725 31 nested-resources 0 9779 new feature patch 2009-01-07T11:11:15-08:00 17123 Ryan Tomayko Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 0.9.1 Ryan Tomayko 17123 0 false 2009-01-17T16:47:45-08:00 9991 --- :milestone: 27725 27724 31 nested-resources 0 9779 new feature patch 2009-01-17T16:47:48-08:00 17123 Ryan Tomayko Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future Ryan Tomayko 0 false 2009-01-18T14:43:05-08:00 9991 --- :assigned_user: 17123 27724 31 nested-resources 0 9779 new feature patch 2009-01-18T14:43:06-08:00 17123 Ryan Tomayko Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 0 I've ported the original patch to master. It's available here: http://github.com/eoin/sinatra/tree/nested_resources <div><p>I've ported the original patch to master. It's available here:</p> <p><a href="http://github.com/eoin/sinatra/tree/nested_resources">http://github.com/eoin/sinatra/t...</a></p></div> false 2009-03-29T15:40:59-07:00 9991 --- {} 27724 31 nested-resources 0 9779 new feature patch 2009-03-29T15:41:01-07:00 16789 Eoin Hennessy Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 0 Cool, thanks for porting it. I keep wanting this - it would make my restful resources in Sinatra so much more succinct. <div><p>Cool, thanks for porting it. I keep wanting this - it would make my restful resources in Sinatra so much more succinct.</p></div> false 2009-04-07T17:48:44-07:00 9991 --- {} 27724 31 nested-resources 0 9779 new feature patch 2009-04-07T17:48:49-07:00 9991 Adam Wiggins Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 0 This looks cool to me. I'd like to see it in a future release. <div><p>This looks cool to me. I'd like to see it in a future release.</p></div> false 2009-09-01T09:33:24-07:00 9991 --- {} 27724 31 nested-resources 0 9779 new feature patch 2009-09-01T09:33:26-07:00 54755 David James Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 0 +1 really like this. I was just about to handroll almost the exact same syntax. Any way this can go into 1.0? <div><p>+1 really like this. I was just about to handroll almost the exact same syntax.</p> <p>Any way this can go into 1.0?</p></div> false 2009-10-15T08:02:43-07:00 9991 --- {} 27724 31 nested-resources 0 9779 new feature patch 2009-10-15T08:02:44-07:00 15459 Nate Wiger Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 0 Looks like a killer feature. I would love to see this in 1.0! <div><p>Looks like a killer feature. I would love to see this in 1.0!</p></div> false 2009-11-14T18:00:38-08:00 9991 --- {} 27724 31 nested-resources 0 9779 new feature patch 2009-11-14T18:00:41-08:00 61850 jho406 (at gmail) Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 0 Awesome feature. Was thinking about implementing such thing on my own. Any reason you place this (an all your other code) in lib/sinatra.rb rather than lib/sinatra/base.rb so one could use this without top level mode? <div><p>Awesome feature. Was thinking about implementing such thing on my own. Any reason you place this (an all your other code) in lib/sinatra.rb rather than lib/sinatra/base.rb so one could use this without top level mode?</p></div> false 2009-12-02T11:09:54-08:00 9991 --- {} 27724 31 nested-resources 0 9779 new feature patch 2009-12-02T11:09:59-08:00 39584 Konstantin Haase Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 0 Here's a patch against Sinatra trunk, with tests, and putting the functionality into Sinatra::Base. I can also send a github pull request. I've also put together a Sinatra::Resources extension, although it seems best that this make it in core, since the extension feels like a bit of Rails-esque method override/dispatch magic. <div><p>Here's a patch against Sinatra trunk, with tests, and putting the functionality into Sinatra::Base. I can also send a github pull request.</p> <p>I've also put together a Sinatra::Resources extension, although it seems best that this make it in core, since the extension feels like a bit of Rails-esque method override/dispatch magic.</p></div> false 2010-01-04T15:48:04-08:00 9991 --- :tag: feature patch 27724 31 nested-resources 0 9779 new "feature patch" 2010-01-04T15:48:08-08:00 15459 Nate Wiger Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 1 FYI the Sinatra::Resources extension is at: http://github.com/nateware/sinatra-resources <div><p>FYI the Sinatra::Resources extension is at: <a href= "http://github.com/nateware/sinatra-resources">http://github.com/nateware/sinatra-resources</a></p></div> false 2010-01-04T15:49:03-08:00 9991 --- {} 27724 31 nested-resources 0 9779 new "feature patch" 2010-01-04T15:49:03-08:00 15459 Nate Wiger Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 1 Nice, Nate! I've wanted this feature in nearly every sinatra app I've written in the past year. The extension works beautifully. <div><p>Nice, Nate! I've wanted this feature in nearly every sinatra app I've written in the past year. The extension works beautifully.</p></div> false 2010-01-06T19:01:40-08:00 9991 --- {} 27724 31 nested-resources 0 9779 new "feature patch" 2010-01-06T19:01:41-08:00 9991 Adam Wiggins Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 1 Good work Nate! This is a feature I'd love to see in Sinatra before 1.0 <div><p>Good work Nate! This is a feature I'd love to see in Sinatra before 1.0</p></div> false 2010-01-14T10:30:53-08:00 9991 --- {} 27724 31 nested-resources 0 9779 new "feature patch" 2010-01-14T10:30:55-08:00 47545 Mike (at coverallcrew) Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 1 false 2010-01-14T21:26:11-08:00 9991 --- :tag: "\"feature patch\"" 27724 31 nested-resources 0 9779 new "feature patch" routes routing 2010-01-14T21:26:14-08:00 15459 Nate Wiger Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 1 From http://groups.google.com/group/sinatrarb/browse_thread/thread/e60f3fa5bc967863 Instead of "resource", if we called it "relative_to" and concentrated on "/path" routes would be more consistent with Sinatra's DSL and goals: relative_to "/posts" do get do # show all posts end get ".json" do # json feed end post do # create new post end relative_to ":id" do get do |id| # show post end delete do |id| # destroy post end get "comments" do |id| # show this post's comments end get "comments.rss" do |id| # newsfeed of comments end end end <div><p>From <a href= "http://groups.google.com/group/sinatrarb/browse_thread/thread/e60f3fa5bc967863"> http://groups.google.com/group/sinatrarb/browse_thread/thread/e60f3...</a></p> <p>Instead of "resource", if we called it "relative_to" and concentrated on "/path" routes would be more consistent with Sinatra's DSL and goals:</p> <pre> <code>relative_to "/posts" do get do # show all posts end get ".json" do # json feed end post do # create new post end relative_to ":id" do get do |id| # show post end delete do |id| # destroy post end get "comments" do |id| # show this post's comments end get "comments.rss" do |id| # newsfeed of comments end end end</code> </pre></div> false 2010-01-16T08:04:44-08:00 9991 --- {} 27724 31 nested-resources 0 9779 new "feature patch" routes routing 2010-01-16T08:04:49-08:00 15459 Nate Wiger Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 1 One problem I found using this is some of my routes have option elements such as (.:format). I've since resorted to building out each resource as a set of routes the "Sinatra way" (:ie get "/my_resource/:id(:.format) ). One thing that I keep coming back to is to figure out a way I can namespace a set of routes (a Resource in the context of this discussion) so I can call a before filter on that set and not everything. This would lead to more robust applications but I believe it would take away from the simplicity of Sinatra, which makes it awesome! <div><p>One problem I found using this is some of my routes have option elements such as (.:format). I've since resorted to building out each resource as a set of routes the "Sinatra way" (:ie get "/my_resource/:id(:.format) ).</p> <p>One thing that I keep coming back to is to figure out a way I can namespace a set of routes (a Resource in the context of this discussion) so I can call a before filter on that set and not everything. This would lead to more robust applications but I believe it would take away from the simplicity of Sinatra, which makes it awesome!</p></div> false 2010-01-21T17:21:30-08:00 9991 --- {} 27724 31 nested-resources 0 9779 new "feature patch" routes routing 2010-01-21T17:21:35-08:00 47545 Mike (at coverallcrew) Adam Wiggins http://sinatra.lighthouseapp.com/projects/9779/tickets/31 Future 1d00ea061fe777fbe50a29d2bd360d8ee0007de9 text/plain 2010-01-04T15:48:04-08:00 sinatra_resource.diff 367321 5557 15459 http://sinatra.lighthouseapp.com/attachments/367321/sinatra_resource.diff