17123 0 true 2009-10-03T13:25:04-07:00 17123 2010-02-08T00:00:00-08:00 41832 247 helpers-for-setting-cache-control-header 9 9779 resolved 2009-10-04T06:29:04-07:00 11306 Simon Rozet Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0 It bugs me that we don't have a helper for setting cache control headers. Something like: @@@ ruby get '/' do cache_control :public, :must_revalidate, :max_age => 60 end @@@ Here's some high level specs for `cache_control`: - Takes a variable number of String or Symbol args for boolean directives (`public`, `no-cache`, `no-store`, `must-revalidate`, `proxy-revalidate`). - Takes an optional single Hash arg for value directives (`:max_age => 60`) - Runs a `s/_/-/g` on all directive keys to get the canonical directive name - Accepts `true` and `false` as directive Hash values. Directives set `false` are not included in the header value; directives set `true` are included as boolean directives (e.g., `:public => true` should yield `Cache-Control: public`). Some concerns: - When a Cache-Control header is already set on the response, should the values given to `cache_control` overwrite the existing value or be merged? - Does this just write `Cache-Control` headers or can it be used to see what directives are already set. For instance, should we make it possible to `if cache_control[:public]` or `cache_control[:max_age]`? It bugs me that we don't have a helper for setting cache control headers. Something like: @@@ ruby get '/' do cache_control :public, :must_revalidate, :max_age => 60 end @@@ Here's some high level specs for `cache_control`: - Takes a variable number of String or Symbol args for boolean directives (`public`, `no-cache`, `no-store`, `must-revalidate`, `proxy-revalidate`). - Takes an optional single Hash arg for value directives (`:max_age => 60`) - Runs a `s/_/-/g` on all directive keys to get the canonical directive name - Accepts `true` and `false` as directive Hash values. Directives set `false` are not included in the header value; directives set `true` are included as boolean directives (e.g., `:public => true` should yield `Cache-Control: public`). Some concerns: - When a Cache-Control header is already set on the response, should the values given to `cache_control` overwrite the existing value or be merged? - Does this just write `Cache-Control` headers or can it be used to see what directives are already set. For instance, should we make it possible to `if cache_control[:public]` or `cache_control[:max_age]`? <div><p>It bugs me that we don't have a helper for setting cache control headers. Something like:</p> <pre><code class="ruby"> get '/' do cache_control :public, :must_revalidate, :max_age =&gt; 60 end </code></pre> <p>Here's some high level specs for <code>cache_control</code>:</p> <ul> <li>Takes a variable number of String or Symbol args for boolean directives (<code>public</code>, <code>no-cache</code>, <code>no-store</code>, <code>must-revalidate</code>, <code>proxy-revalidate</code>).</li> <li>Takes an optional single Hash arg for value directives (<code>:max_age =&gt; 60</code>)</li> <li>Runs a <code>s/_/-/g</code> on all directive keys to get the canonical directive name</li> <li>Accepts <code>true</code> and <code>false</code> as directive Hash values. Directives set <code>false</code> are not included in the header value; directives set <code>true</code> are included as boolean directives (e.g., <code>:public =&gt; true</code> should yield <code>Cache-Control: public</code>).</li> </ul> <p>Some concerns:</p> <ul> <li> <p>When a Cache-Control header is already set on the response, should the values given to <code>cache_control</code> overwrite the existing value or be merged?</p> </li> <li> <p>Does this just write <code>Cache-Control</code> headers or can it be used to see what directives are already set. For instance, should we make it possible to <code>if cache_control[:public]</code> or <code>cache_control[:max_age]</code>?</p> </li> </ul></div> 17123 0 It bugs me that we don't have a helper for setting cache control headers. Something like: @@@ ruby get '/' do cache_control :public, :must_revalidate, :max_age => 60 end @@@ Here's some high level specs for `cache_control`: - Takes a variable number of String or Symbol args for boolean directives (`public`, `no-cache`, `no-store`, `must-revalidate`, `proxy-revalidate`). - Takes an optional single Hash arg for value directives (`:max_age => 60`) - Runs a `s/_/-/g` on all directive keys to get the canonical directive name - Accepts `true` and `false` as directive Hash values. Directives set `false` are not included in the header value; directives set `true` are included as boolean directives (e.g., `:public => true` should yield `Cache-Control: public`). Some concerns: - When a Cache-Control header is already set on the response, should the values given to `cache_control` overwrite the existing value or be merged? - Does this just write `Cache-Control` headers or can it be used to see what directives are already set. For instance, should we make it possible to `if cache_control[:public]` or `cache_control[:max_age]`? <div><p>It bugs me that we don't have a helper for setting cache control headers. Something like:</p> <pre> <code class="ruby">get '/' do cache_control :public, :must_revalidate, :max_age =&gt; 60 end</code> </pre> <p>Here's some high level specs for <code>cache_control</code>:</p> <ul> <li>Takes a variable number of String or Symbol args for boolean directives (<code>public</code>, <code>no-cache</code>, <code>no-store</code>, <code>must-revalidate</code>, <code>proxy-revalidate</code>).</li> <li>Takes an optional single Hash arg for value directives (<code>:max_age =&gt; 60</code>)</li> <li>Runs a <code>s/_/-/g</code> on all directive keys to get the canonical directive name</li> <li>Accepts <code>true</code> and <code>false</code> as directive Hash values. Directives set <code>false</code> are not included in the header value; directives set <code>true</code> are included as boolean directives (e.g., <code>:public =&gt; true</code> should yield <code>Cache-Control: public</code>).</li> </ul> <p>Some concerns:</p> <ul> <li> <p>When a Cache-Control header is already set on the response, should the values given to <code>cache_control</code> overwrite the existing value or be merged?</p> </li> <li> <p>Does this just write <code>Cache-Control</code> headers or can it be used to see what directives are already set. For instance, should we make it possible to <code>if cache_control[:public]</code> or <code>cache_control[:max_age]</code>?</p> </li> </ul></div> false 2009-06-08T00:53:51-07:00 17123 --- {} 41832 247 helpers-for-setting-cache-control-header 0 9779 new 2009-06-08T00:53:54-07:00 17123 Ryan Tomayko Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0 17123 0 I played with this for an hour or so tonight and pushed the result to the "rtomayko/cachecontrol" branch: http://github.com/rtomayko/sinatra/commit/8c767c91d4b8c083ff4b0bc53c70fd09c1eb95a4 I don't totally love it but it might be a good start. <div><p>I played with this for an hour or so tonight and pushed the result to the "rtomayko/cachecontrol" branch:</p> <p><a href= "http://github.com/rtomayko/sinatra/commit/8c767c91d4b8c083ff4b0bc53c70fd09c1eb95a4"> http://github.com/rtomayko/sinatra/commit/8c767c91d4b8c083ff4b0bc53...</a></p> <p>I don't totally love it but it might be a good start.</p></div> false 2009-06-08T02:02:31-07:00 17123 --- :state: new 41832 247 helpers-for-setting-cache-control-header 0 9779 open 2009-06-08T02:02:36-07:00 17123 Ryan Tomayko Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0 17123 0 Looks great IMO. Any reason you didn't push it yet? <div><p>Looks great IMO. Any reason you didn't push it yet?</p></div> false 2009-06-27T14:55:19-07:00 17123 --- {} 41832 247 helpers-for-setting-cache-control-header 0 9779 open 2009-06-27T14:55:24-07:00 11306 Simon Rozet Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0 17123 0 Looks good to me. As for your concerns I'd imagine merging, with these options overriding, would be sensible. And the ability to see what's already set might be helpful. Any reason not to have rack-cache provide this in a leaner require instead of duplicating it? Just seems like two options with people using rack-cache. <div><p>Looks good to me. As for your concerns I'd imagine merging, with these options overriding, would be sensible. And the ability to see what's already set might be helpful.</p> <p>Any reason not to have rack-cache provide this in a leaner require instead of duplicating it? Just seems like two options with people using rack-cache.</p></div> false 2009-08-13T04:58:09-07:00 17123 --- {} 41832 247 helpers-for-setting-cache-control-header 0 9779 open 2009-08-13T04:58:10-07:00 6664 Dylan Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0 17123 0 Ryan, IMO these helpers do exactly what I'd expect from Sinatra; small and simple just like the `etag` and `last_modified` ones. I didn't write actual code to try it but wouldn't merging introduce complexity? How'd your merge `cache_control :public, :must_revalidate, :max_age => 60` with `cache_control :private, :max_age => 10` for example? It could lead to confusion. Regarding querying, what's the use case? When used as a middleware? Anyway, I think this could be merged as is for now. <div><p>Ryan, IMO these helpers do exactly what I'd expect from Sinatra; small and simple just like the <code>etag</code> and <code>last_modified</code> ones. I didn't write actual code to try it but wouldn't merging introduce complexity? How'd your merge <code>cache_control :public, :must_revalidate, :max_age =&gt; 60</code> with <code>cache_control :private, :max_age =&gt; 10</code> for example? It could lead to confusion. Regarding querying, what's the use case? When used as a middleware? Anyway, I think this could be merged as is for now.</p></div> false 2009-10-03T13:25:04-07:00 17123 --- {} 41832 247 helpers-for-setting-cache-control-header 0 9779 open 2009-10-03T13:26:22-07:00 11306 Simon Rozet Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0 17123 0 Yeah. I'm +1 to go with what's there. <div><p>Yeah. I'm +1 to go with what's there.</p></div> false 2009-10-04T01:41:16-07:00 17123 --- {} 41832 247 helpers-for-setting-cache-control-header 0 9779 open 2009-10-04T01:41:18-07:00 17123 Ryan Tomayko Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0 17123 0 (from [c6ea22bb8ff4c8354328db4fa60023c7d494c9bf]) Add cache_control and expires helper methods [#247] http://github.com/sinatra/sinatra/commit/c6ea22bb8ff4c8354328db4fa60023c7d494c9bf <div><p>(from <a href= "/projects/9779/changesets/c6ea22bb8ff4c8354328db4fa60023c7d494c9bf" title= "Changeset [c6ea22bb8ff4c8354328db4fa60023c7d494c9bf]">[c6ea22bb8ff4c8354328db4fa60023c7d494c9bf]</a>) Add cache_control and expires helper methods [<a href= "/projects/9779/tickets/247" title="Ticket #247">#247</a>] <a href= "http://github.com/sinatra/sinatra/commit/c6ea22bb8ff4c8354328db4fa60023c7d494c9bf"> http://github.com/sinatra/sinatra/commit/c6ea22bb8ff4c8354328db4fa6...</a></p></div> false 2009-10-04T06:28:54-07:00 17123 --- {} 41832 247 helpers-for-setting-cache-control-header 0 9779 open 2009-10-04T06:28:54-07:00 17123 Ryan Tomayko Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0 17123 0 true 2009-10-04T06:29:01-07:00 17123 --- :state: open 41832 247 helpers-for-setting-cache-control-header 0 9779 resolved 2009-10-04T06:29:04-07:00 11306 Simon Rozet Ryan Tomayko Ryan Tomayko http://sinatra.lighthouseapp.com/projects/9779/tickets/247 1.0