[PATCH] Unnecessary error code handling in Error class
Reported by Jonas Nicklas | July 6th, 2008 @ 08:00 AM | in 0.3.0 Sammy
The Sinatra::Error class is initialized with an error code, however that code doesn't seem to be used anywhere.
Also in the documentation for Sinatra::Application#error, the example given specifies a custom error code, suggesting that this is the intended usage.
The code passed to the Error class from the Sinatra::Application#error method is the class of the custom error handler, which doesn't really seem right.
This patch removes the redundant code from Sinatra::Error.
Comments and changes to this ticket
-
Ryan Tomayko September 7th, 2008 @ 07:40 AM
- → Tag changed from “patch” to “fixed patch”
Yeah. Error handling was a mess in general. I've incorporated this patch and made a few other fixes on my master.
-
Ryan Tomayko September 7th, 2008 @ 06:13 PM
- → State changed from “new” to “resolved”
- → Assigned user changed from “Blake Mizerany” to “Ryan Tomayko”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Blake Mizerany